raminqaf commented on code in PR #28510:
URL: https://github.com/apache/flink/pull/28510#discussion_r3499529133
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/table/SqlReplaceTableAsConverter.java:
##########
@@ -31,35 +29,22 @@
import org.apache.flink.table.operations.ddl.CreateTableOperation;
import org.apache.flink.table.planner.calcite.FlinkPlannerImpl;
import org.apache.flink.table.planner.operations.PlannerQueryOperation;
-import org.apache.flink.table.planner.operations.SqlNodeToOperationConversion;
import org.apache.flink.table.planner.operations.converters.MergeTableAsUtil;
import java.util.List;
import java.util.Map;
import java.util.Optional;
+import static
org.apache.flink.table.planner.operations.converters.SqlNodeConvertUtils.convertAsQuery;
+
/** A converter for {@link SqlReplaceTableAs}. */
public class SqlReplaceTableAsConverter extends
AbstractCreateTableConverter<SqlReplaceTableAs> {
@Override
public Operation convertSqlNode(SqlReplaceTableAs sqlReplaceTableAs,
ConvertContext context) {
- CatalogManager catalogManager = context.getCatalogManager();
FlinkPlannerImpl flinkPlanner = context.getFlinkPlanner();
- PlannerQueryOperation query =
- (PlannerQueryOperation)
- SqlNodeToOperationConversion.convert(
- flinkPlanner,
- catalogManager,
- sqlReplaceTableAs.getAsQuery())
- .orElseThrow(
- () ->
- new TableException(
- "RTAS unsupported node
type "
- +
sqlReplaceTableAs
-
.getAsQuery()
-
.getClass()
-
.getSimpleName()));
+ PlannerQueryOperation query =
convertAsQuery(sqlReplaceTableAs.getAsQuery(), context);
Review Comment:
I have reverted the changes to the CTAS and RTAS for now, to keep this PR
small and prevent side effects
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
