MartijnVisser commented on PR #28440: URL: https://github.com/apache/flink/pull/28440#issuecomment-4847827339
Hi @qiuyanjun888, a heads-up on a small overlap. My Angular 21 upgrade (#28593, FLINK-40028) also touches the web-dashboard, and it ran into exactly the drift this PR is meant to catch: regenerating the lockfile bumped prettier within `^2.4.1` (2.6.2 -> 2.8.8), and prettier 2.7+ strips the indentation inside HTML comments, which reformatted the ASF license headers. The `--cache` masked it locally, so it only surfaced in review. In other words, had this PR landed first, my CI would have caught the drift during development. The two changes are complementary, and a test-merge of the branches is clean. The only incidental overlap is the identical `job-exceptions.component.less` property reorder (a stylelint-order autofix that both PRs happen to include). I've pinned prettier back to 2.6.2 in #28593 so it carries no header churn, but I think your cache removal is the better root-cause fix. No changes needed on your side, just flagging for merge sequencing. Happy for this one to go in first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
