weiqingy commented on code in PR #856: URL: https://github.com/apache/flink-agents/pull/856#discussion_r3502125552
########## docs/content/docs/faq/faq.md: ########## @@ -87,7 +87,7 @@ This is important because: - **For Java users on JDK 21+**: Async execution is available. - **For Java users on JDK < 21**: Async execution is not available and falls back to synchronous execution. -> **Cross-language async note**: Async execution for cross-language resources requires the pemja 0.5.7 fix, available in Flink 1.20.5+ / 2.0.2+ / 2.1.3+ / 2.2.1+. Current builds target Flink 2.2.0, so cross-language calls still run synchronously for now; this is resolved automatically once running on a Flink version that includes the fix. +> **Cross-language async note**: Async execution for cross-language resources requires the pemja 0.5.7 fix, available in Flink 1.20.5+ / 2.0.2+ / 2.1.3+ / 2.2.1+ / 2.3+. Current builds target Flink 2.2.1, which includes the fix, so cross-language async is enabled by default; on older Flink versions it falls back to synchronous execution automatically. Review Comment: This line still reads `Current builds target Flink 2.2.1`, but the root `flink.version` now defaults to `2.3.0` (`pom.xml:44`) — looks like the version number didn't follow the default bump. Should it be `2.3.0`? The rest of the sentence (the fix is present, so async is on by default) holds either way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
