davidradl commented on PR #50: URL: https://github.com/apache/flink-connector-http/pull/50#issuecomment-4855008671
@bharathgunapati I have asked my AI to review this and it came up with : One blocking issue: [archunit-junit5-engine](https://github.com/TNG/ArchUnit) is missing from both POMs. Only archunit-junit5-api (annotations) is declared. Without the JUnit Platform engine, all @ArchTest fields are silently skipped — the build goes green because the tests never run, not because they pass. Fix: swap both archunit-junit5-api and archunit for the archunit-junit5 convenience bundle (which includes the engine). Frozen violations worth noting: 56 violations of using non-public Flink internals — primarily shaded Jackson being used directly in JavaNetHttpPollingClient, OidcAccessTokenManager, and GenericJsonAndUrlQueryCreator. Freezing is correct here to get the gate in, but these warrant follow-up JIRAs. 1 violation where production code calls a @VisibleForTesting method — a genuine code smell that should be fixed, not just frozen. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
