yuchengxin commented on PR #28310:
URL: https://github.com/apache/flink/pull/28310#issuecomment-4855230920
Thanks for the review.
I updated the patch to address the main points:
- fixed timeout replacement-future recycling on the exceptional path in
`AsyncLookupJoinRunner`,
- strengthened `AsyncTableFunction.timeout(...)` validation to check
`CompletableFuture<Collection<T>>` and the matching `eval(...)` contract,
- removed the unnecessary debug logging change,
- tightened the timeout-related regression tests to use stronger semantic
assertions and less brittle synchronization.
I also updated the commit-message disclosure to use `Generated-by:` instead
of the previous AI co-author trailer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
