[
https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839466#comment-15839466
]
ASF GitHub Bot commented on FLINK-2168:
---------------------------------------
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3149#discussion_r97955449
--- Diff:
flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/HBaseTableSchema.java
---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.flink.addons.hbase;
+
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.typeutils.TypeExtractor;
+import org.apache.flink.util.Preconditions;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.hbase.util.Pair;
+
+import java.io.Serializable;
+import java.math.BigDecimal;
+import java.math.BigInteger;
+import java.sql.Time;
+import java.util.List;
+import java.util.Map;
+import java.util.HashMap;
+import java.util.ArrayList;
+import java.sql.Date;
+
+/**
+ * Helps to specify an HBase Table's schema
+ */
+public class HBaseTableSchema implements Serializable {
+
+ // A Map with key as column family.
+ private final Map<String, List<Pair<String, TypeInformation<?>>>>
familyMap =
+ new HashMap<>();
+
+ // Allowed types. This may change.
+ // TODO : Check if the Date type should be the one in java.util or the
one in java.sql
+ private static Class[] CLASS_TYPES = {
+ Integer.class, Short.class, Float.class, Long.class,
String.class, Byte.class, Boolean.class, Double.class, BigInteger.class,
BigDecimal.class, Date.class, Time.class, byte[].class
+ };
+ /**
+ * Allows specifying the family and qualifier name along with the data
type of the qualifier for an HBase table
+ *
+ * @param family the family name
+ * @param qualifier the qualifier name
+ * @param clazz the data type of the qualifier
+ */
+ public void addColumn(String family, String qualifier, Class<?> clazz) {
+ Preconditions.checkNotNull(family, "family name");
+ Preconditions.checkNotNull(qualifier, "qualifier name");
+ Preconditions.checkNotNull(clazz, "class type");
+ List<Pair<String, TypeInformation<?>>> list =
this.familyMap.get(family);
+ if (list == null) {
+ list = new ArrayList<>();
+ }
+ boolean found = false;
+ for (Class classType : CLASS_TYPES) {
+ if (classType == clazz) {
+ found = true;
+ break;
+ }
+ }
+ if (!found) {
+ // throw exception
+ throw new IllegalArgumentException("Unsupported class
type found " + clazz);
+ }
+ list.add(new Pair<String, TypeInformation<?>>(qualifier,
TypeExtractor.getForClass(clazz)));
+ familyMap.put(family, list);
+ }
+
+ public String[] getFamilyNames() {
+ return this.familyMap.keySet().toArray(new
String[this.familyMap.size()]);
+ }
+
+ public String[] getQualifierNames(String family) {
+ List<Pair<String, TypeInformation<?>>> colDetails =
familyMap.get(family);
+ String[] qualifierNames = new String[colDetails.size()];
+ int i = 0;
+ for (Pair<String, TypeInformation<?>> pair : colDetails) {
+ qualifierNames[i] = pair.getFirst();
+ i++;
+ }
+ return qualifierNames;
+ }
+
+ public TypeInformation<?>[] getTypeInformation(String family) {
--- End diff --
Rename to `getQualifierTypes` ? This can keep consistent to
`getQualifierNames`. The `getTypeInformation` is a little mislead IMO.
> Add HBaseTableSource
> --------------------
>
> Key: FLINK-2168
> URL: https://issues.apache.org/jira/browse/FLINK-2168
> Project: Flink
> Issue Type: New Feature
> Components: Table API & SQL
> Affects Versions: 0.9
> Reporter: Fabian Hueske
> Assignee: ramkrishna.s.vasudevan
> Priority: Minor
> Labels: starter
>
> Add a {{HBaseTableSource}} to read data from a HBase table. The
> {{HBaseTableSource}} should implement the {{ProjectableTableSource}}
> (FLINK-3848) and {{FilterableTableSource}} (FLINK-3849) interfaces.
> The implementation can be based on Flink's {{TableInputFormat}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
