haruki-830 commented on code in PR #4437:
URL: https://github.com/apache/flink-cdc/pull/4437#discussion_r3518555204
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-postgres/src/main/java/org/apache/flink/cdc/connectors/postgres/source/PostgresDataSourceOptions.java:
##########
@@ -281,4 +281,17 @@ public class PostgresDataSourceOptions {
.defaultValue(false)
.withDescription(
"Whether to infer CDC column types when processing
pgoutput Relation messages.");
+
+ @Experimental
+ public static final ConfigOption<String> CHANGELOG_MODE =
+ ConfigOptions.key("changelog-mode")
+ .stringType()
+ .defaultValue("all")
Review Comment:
I noticed the existing SQL connector (flink-connector-postgres-cdc) defines
this option using enumType(DebeziumChangelogMode.class). It might be worth
aligning with that approach — it would give us compile-time safety and also
avoid the null handling concern in the factory. Something like:
```
public static final ConfigOption<DebeziumChangelogMode> CHANGELOG_MODE =
ConfigOptions.key("changelog-mode")
.enumType(DebeziumChangelogMode.class)
.defaultValue(DebeziumChangelogMode.ALL);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
