bharathgunapati commented on PR #52: URL: https://github.com/apache/flink-connector-http/pull/52#issuecomment-4883401687
Hi @davidradl — would you be able to review this when you have a moment? This is a follow-up to FLINK-39364 (#31): `request.timeout` was declared as a `ConfigOption<Duration>` but the runtime still parsed it with `Integer.parseInt(...)`, so values like `'30s'` crashed at query time with `NumberFormatException`. This PR wires the runtime to the declared option on both lookup and sink paths. A few things that may help review: - **JIRA:** [FLINK-40072](https://issues.apache.org/jira/browse/FLINK-40072) (includes release note for the `'30'` → `'30s'` migration) - **Repro branch** (optional): `demo/FLINK-40072-request-timeout-repro` on my fork — a single ITCase that asserts the pre-fix `NumberFormatException` on unmodified code - **Sink scope:** lookup reads via `ReadableConfig`; sink still reads from the `Properties` bag but parses with `TimeUtils.parseDuration(...)` — I left full sink config unification for a separate follow-up PR Happy to adjust anything based on your feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
