Manishnemade12 commented on PR #27969: URL: https://github.com/apache/flink/pull/27969#issuecomment-4969953016
@snuyanzin JIRA: Agreed, will create a dedicated ticket and update the PR title. Tests: Will add two unit tests - one injecting IOException during DFS copy to verify temp file cleanup, another triggering failure on FileChannel.position() to verify the FileInputStream is closed. 2.1: Both bugs are confirmed by code reading downloadToCacheFile never calls file.delete() in its catch block (orphaned temp file), and openAndSeek never closes fin if position() throws (leaked FD). 2.2: I'll add unit tests that explicitly exercise both error paths. If any future commit breaks the cleanup, these tests will fail in CI that's the regression safety net. Let me know if this works , I'll update the PR accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
