Savonitar commented on code in PR #28709:
URL: https://github.com/apache/flink/pull/28709#discussion_r3588237127
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/metadata/MetadataV3Serializer.java:
##########
@@ -270,7 +285,7 @@ public static StreamStateHandle
deserializeStreamStateHandle(DataInputStream dis
@VisibleForTesting
public void serializeOperatorStateHandleUtil(
OperatorStateHandle stateHandle, DataOutputStream dos) throws
IOException {
- serializeOperatorStateHandle(stateHandle, dos);
+ serializeOperatorStateHandle(stateHandle, dos, null);
Review Comment:
These are `@VisibleForTesting `helpers used only from test code, they serdez
standalone handles outside any checkpoint, so there is no "exclusive directory"
to check relative references, that's why null is the only meaningful context
there.
I added clarifications in
https://github.com/apache/flink/pull/28709/changes/30c2e72cd3a2b00ec1b06e2480ac380c660bfca2
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/metadata/MetadataV3Serializer.java:
##########
@@ -270,7 +285,7 @@ public static StreamStateHandle
deserializeStreamStateHandle(DataInputStream dis
@VisibleForTesting
public void serializeOperatorStateHandleUtil(
OperatorStateHandle stateHandle, DataOutputStream dos) throws
IOException {
- serializeOperatorStateHandle(stateHandle, dos);
+ serializeOperatorStateHandle(stateHandle, dos, null);
Review Comment:
These are `@VisibleForTesting` helpers used only from test code, they serdes
standalone handles outside any checkpoint, so there is no "exclusive directory"
to check relative references, that's why null is the only meaningful context
there.
I added clarifications in
https://github.com/apache/flink/pull/28709/changes/30c2e72cd3a2b00ec1b06e2480ac380c660bfca2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
