SteveStevenpoor commented on code in PR #28689:
URL: https://github.com/apache/flink/pull/28689#discussion_r3593595696
##########
flink-runtime/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java:
##########
@@ -848,12 +848,16 @@ private void checkSplitWatermarkAlignment() {
Collection<String> splitsToResume = new ArrayList<>();
sampledSplitWatermarks.forEach(
(splitId, splitWatermarks) -> {
- if (currentlyIdleSplits.contains(splitId)) {
- return;
- }
if (splitWatermarks.getOldestSample() >
currentMaxDesiredWatermark) {
Review Comment:
> > we mark an idle split as paused: markPaused() marks it as not idle, but
the split remains in currentlyIdleSplits.
>
> Pause is
[skipped](https://github.com/apache/flink/pull/28689/files#diff-2339da634e6ff41e35286bc5c6cef610b63fd39751fc75e1ad4d817e214c9451R853-R856)
for idle splits.
Yeah, I mean the case when the split is marked idle _during_ the pause
process (it was not idle at decision time, so it could still be added to
splitToPause).
Anyway, I agree this is probably not a blocker for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
