haruki-830 commented on PR #4474:
URL: https://github.com/apache/flink-cdc/pull/4474#issuecomment-4998296354
> Also, to ease review, consider splitting this so buckets 1–2 and bucket 3
land as separate commits (or separate PRs) — the crash/parse fixes can then be
merged quickly, while the semantic change is reviewed on its own.
Thanks for the detailed review and the compatibility analysis. I agree with
the split.
I will separate this work into two PRs:
1. The first PR will only include the always-on changes with no silent
behavior change:
- newly supported operators that are currently unparseable, such as `IS
[NOT] DISTINCT FROM`, `IS [NOT] UNKNOWN`, `SIMILAR TO` / `NOT SIMILAR TO`, and
`LIKE ... ESCAPE`
- NULL boolean crash fixes for `AND`, `OR`, `NOT`, `IS [NOT] TRUE`, and
`IS [NOT] FALSE`
2. The second PR will handle the backward-incompatible semantic changes
behind an explicit option:
- comparison predicates, `IN`, `BETWEEN`, and legacy `LIKE` / `NOT LIKE`
- add `pipeline.transform.expression.semantics` with `LEGACY` as the
default and `FLINK_SQL` as the opt-in SQL-compatible behavior
This should allow the parse/crash fixes to move forward independently, while
keeping the silent result-changing semantics isolated and explicitly gated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
