pnowojski commented on code in PR #28752:
URL: https://github.com/apache/flink/pull/28752#discussion_r3601928823
##########
flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java:
##########
@@ -611,6 +611,29 @@ public class CheckpointingOptions {
+ " For this feature to be enabled, it
must be also supported by the operator."
+ " Currently this is supported by all
TableStreamOperators and CepOperator.");
+ /**
+ * Controls whether an intermediate watermark is emitted while a watermark
advance is
+ * interrupted before completing (see {@link
#ENABLE_UNALIGNED_INTERRUPTIBLE_TIMERS}). Has no
+ * effect unless interruptible timers are enabled. The emission interval
is governed by {@link
+ * PipelineOptions#AUTO_WATERMARK_INTERVAL}, the same as regular periodic
watermark generation,
+ * since both have comparable performance implications.
+ */
+ @Experimental
+ public static final ConfigOption<Boolean>
+ UNALIGNED_INTERRUPTIBLE_TIMERS_EMIT_INTERMEDIATE_WATERMARKS =
+ ConfigOptions.key(
+
"execution.checkpointing.unaligned.interruptible-timers.emit-intermediate-watermarks")
+ .booleanType()
+ .defaultValue(true)
Review Comment:
Potential impact is low tbh, and it's easy to disable this feature. On the
other hand we have a very bad track record of actually enabling good features
by default later on and in hindsight we are far too conservative when it comes
to changing the defaults. So I'm quite strongly inclined to enable it by
default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
