RocMarshal commented on code in PR #28353: URL: https://github.com/apache/flink/pull/28353#discussion_r3614076749
########## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/EarlyFireJoinHintOptions.java: ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.api.config; + +import org.apache.flink.annotation.PublicEvolving; +import org.apache.flink.configuration.ConfigOption; + +import org.apache.flink.shaded.guava33.com.google.common.collect.ImmutableSet; + +import java.time.Duration; +import java.util.HashSet; +import java.util.Set; + +import static org.apache.flink.configuration.ConfigOptions.key; + +/** + * This class holds hint option name definitions for EARLY_FIRE join hints based on {@link + * org.apache.flink.configuration.ConfigOption}. + */ +@PublicEvolving +public class EarlyFireJoinHintOptions { + + public static final ConfigOption<Duration> DELAY = + key("delay") + .durationType() + .noDefaultValue() + .withDescription( + "The delay between the time an unmatched outer row becomes eligible to" + + " be emitted with null padding and the time it is actually" + + " emitted. Must be a positive duration."); + + public static final ConfigOption<TimeMode> TIME_MODE = + key("time_mode") Review Comment: Thanks @weiqingy In my limited reading, There're no options naming like [xxx_yyy], but in [xxx-yyy]. Could we use the `xxx-yyy` format if no special reasons? [1] https://nightlies.apache.org/flink/flink-docs-release-2.3/docs/deployment/config/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
