fhueske commented on PR #28675: URL: https://github.com/apache/flink/pull/28675#issuecomment-5023048511
Thanks for your review @davidradl >checkDisabledSystemArgs passes true hardcoded instead of reading from inference `SystemTypeInference.checkNoSystemArguments()` is also called from `ResolveCallByArgumentsRule` (the Table API path) without a `true` literal. > The public modifier on JUnit 5 test methods in MLPredictTableFunctionTest is unnecessary and > Test method naming inconsistency I've addressed @snuyanzin comment for the new test methods that I added and left the existing ones because their override method from their parent class. > Error message is slightly generic @twalthr suggested a new error message that should also address your point. I've updated the PR. > I was thinking about system argument names with the wrong type I've added a test for this. Thank you, Fabian -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
