gustavodemorais commented on PR #28688:
URL: https://github.com/apache/flink/pull/28688#issuecomment-5032944028
Thanks for the update, @VasShabu. I went through all reviews, list of open
things to be closed
1. Create ticket for the trailing-token bug that affects all json functions
2. VARIANT input. You added the type to the definition, but no tests. If we
support something, we should have tests. If we don't support it, we should have
a test catching the error.
3. javadoc examples missing
4. JSON_EXISTS wildcard test missing
5. Simplify ITCase:186 (CURRENT) — the JSON_EXISTS+JSON_LENGTH compound test.
6. SqlJsonUtils:425 "can it be array?" (snuyanzin)
7. EN doc still shows {"1": "hello", "2": "bye bye"} + path $.2 (lines
1228/1237)
Please double check by going through the reviews and current state
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
