jigar-bhati commented on code in PR #267:
URL:
https://github.com/apache/flink-connector-kafka/pull/267#discussion_r3626598319
##########
flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/KafkaDynamicTableFactoryTest.java:
##########
@@ -474,15 +474,33 @@ public void testTableSourceSetOffsetReset(final String
strategyName) {
testSetOffsetResetForStartFromGroupOffsets(strategyName);
}
- @Test
- void testTableSourceSetOffsetResetWithException() {
Review Comment:
Restored and expanded this coverage. Invalid values are now rejected early
for all five SQL startup modes (earliest, latest, specific offsets, timestamp,
and group offsets), with the existing clear validation error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]