francis-a opened a new pull request, #28801:
URL: https://github.com/apache/flink/pull/28801

   ## What is the purpose of the change
   
   This PR aims to fix the issue documented in 
https://issues.apache.org/jira/browse/FLINK-37686 where remote objects cleaned 
up by the JM cause checkpoint failures even when the object is marked as 
`NOT_OWNED`.
   
   
   ## Brief change log
   
     - Added a `FileNotFoundException` catch block to 
`ForStFlinkFileSystem::listStatus`
     - In this catch block we verify the object is `NOT_OWNED`
     - If true, we assume the JM removed this object and delete it using the 
`FileMappingManager`
     - Tests have been added to cover this case as well as ensuring the 
exception still bubbles up if the object is **not** `NOT_OWNED`
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   - Added two new tests to `ForStFlinkFileSystemTest`,  
`testListStatusDropsDeletedNotOwnedEntryAfterGiveUpOwnership` and 
`testListStatusStillFailsForDeletedDbOwnedFile`
   - These tests cover the `NOT_OWNED` and verify the removed object is also 
removed from the `FileMappingManager`, the other test verifies the baseline 
hasn't changed for other object types
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
     - The serializers: (yes / no / don't know)
     - The runtime per-record code paths (performance sensitive): (don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   
   - [X] Yes
   
   Generated-by: [Claude Opus]
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to