joeyutong commented on code in PR #923:
URL: https://github.com/apache/flink-agents/pull/923#discussion_r3643417225
##########
python/flink_agents/api/events/event.py:
##########
@@ -96,35 +115,44 @@ def model_dump_json(self, **kwargs: Any) -> str:
# Set fallback if not provided in kwargs
if "fallback" not in kwargs:
kwargs["fallback"] = self.__serialize_unknown
+ if "by_alias" not in kwargs:
Review Comment:
Defaulting `by_alias` to `True` here changes serialization for every alias
declared by a custom Event subclass, not only the two lineage fields. Could the
camelCase mapping be scoped to the lineage fields, or should this broader
compatibility change be documented and covered by a custom-alias test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
