hulincup commented on code in PR #962:
URL: https://github.com/apache/flink-agents/pull/962#discussion_r3710653435
##########
python/flink_agents/api/yaml/tests/test_aliases.py:
##########
@@ -127,6 +127,36 @@ def test_resolve_clazz_default_language_is_python() ->
None:
assert default == explicit
+def test_resolve_clazz_covers_chat_model_java_gemini_and_azure_openai() ->
None:
+ assert resolve_clazz("gemini", ResourceType.CHAT_MODEL_CONNECTION,
"java").endswith(
+ "GeminiChatModelConnection"
+ )
+ assert resolve_clazz("gemini", ResourceType.CHAT_MODEL, "java").endswith(
+ "GeminiChatModelSetup"
+ )
+ assert resolve_clazz(
+ "azure_openai", ResourceType.CHAT_MODEL_CONNECTION, "java"
+ ).endswith("AzureOpenAIChatModelConnection")
Review Comment:
Good catch, thanks. ab251a7 pins the package on both the connection and
setup assertions for `azure_openai` — `startswith("org.apache.flink.agents")`
plus the existing `endswith`, mirroring
`test_resolve_clazz_dispatches_on_language`. It's the only one of the six where
the Java/Python simple names collide, so the other five keep the
`endswith`-only form. `13 passed` locally on `test_aliases.py`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
