1996fanrui commented on PR #28920: URL: https://github.com/apache/flink/pull/28920#issuecomment-5197121612
Thanks for the fix. Two questions: 1. The gate now closes while capacity is still unused, so a cycle always emits less than `capacityPerCycle` and never reaches it — with `capacityPerCycle=100` and 6 events per request, every cycle stops at 96. 2. A single request larger than the cycle capacity still exceeds it: with `capacityPerCycle=100` and `acquire(10000)`, the first cycle emits nothing and then every following checkpoint releases the whole 10000, since `notifyCheckpointComplete` resets `capacityLeft` and drops the negative balance. So we neither reach `capacityPerCycle` in the first case nor stay within it in the second. How do you think we should handle this? Fine with me if this is the accepted behaviour. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
