weiqingy commented on code in PR #28827:
URL: https://github.com/apache/flink/pull/28827#discussion_r3737890802
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/physical/stream/StreamPhysicalIntervalJoinRule.java:
##########
@@ -170,6 +170,12 @@ private static EarlyFire extractEarlyFire(List<RelHint>
hints, boolean isEventTi
}
Configuration conf = Configuration.fromMap(earlyFireHint.kvOptions);
+ // target scopes the hint to one operator kind: this rule applies it
only when it targets
+ // the interval join, and leaves a hint aimed at any other operator
kind untouched.
+ String target = conf.get(EarlyFireJoinHintOptions.TARGET);
+ if (target != null &&
!EarlyFireJoinHintOptions.INTERVAL_JOIN.equals(target)) {
Review Comment:
Sounds good. I reverted it in 7e6ff3adcc4.
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/EarlyFireJoinHintOptions.java:
##########
@@ -36,6 +36,18 @@
@PublicEvolving
public class EarlyFireJoinHintOptions {
+ /** The only operator kind the EARLY_FIRE hint applies to. */
Review Comment:
Reworded to "currently supports". `target` exists so a future operator kind
can opt in explicitly, so this constant should not read as a permanent contract.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
