weiqingy commented on PR #28877: URL: https://github.com/apache/flink/pull/28877#issuecomment-5224568908
Hi @RocMarshal, #28827 is merged, so this one is rebased onto master and out of draft. The diff is standalone now: 5 files, adding update-producing changelog inference for an early-fire outer interval join. One thing worth flagging: this changes an existing test's sink. `MySink` in `EarlyFireJoinHintTest` was insert-only, and an early-fire outer join now produces updates, so `testEarlyFireJsonPlanRoundTrip` no longer plans against it. I declared `sink-insert-only=false` on that sink rather than weakening the test. That is the one existing behavior this PR changes. PTAL when you have a moment. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
