weiqingy opened a new pull request, #979: URL: https://github.com/apache/flink-agents/pull/979
Linked issue: n/a (hotfix) ### Purpose of change `pip` is not guaranteed to be on PATH. A Python install commonly exposes only `pip3`, or exposes pip solely as a module, in which case the bare command is not found and the script stops. `tools/build.sh:104` is the one that bites hardest, because it runs unconditionally rather than behind the `command -v uv` check the other scripts use. The Python half of the build fails before it starts: ``` ./tools/build.sh: line 104: pip: command not found ``` The two `pip` calls in `tools/lint.sh` and the two in `tools/ut.sh` sit in the no-`uv` fallback path and fail the same way once that path is taken. This invokes pip through the interpreter instead. `tools/install.sh` already uses `python -m pip`, so this makes the rest of the scripts consistent with it. ### Tests CI is unaffected, since the runners provide a bare `pip` and both forms resolve to the same pip there. The change is only observable where a bare `pip` was absent, which is exactly the case that used to fail. Reproduced on a machine where the system Python exposes no bare `pip`: ``` $ python3 -m pip --version pip 21.2.4 from .../python3.9/site-packages/pip (python 3.9) $ pip --version command not found: pip ``` `bash -n` passes on all three scripts, and no bare `pip` invocation remains under `tools/`. No behavior change where a bare `pip` already resolved: `python3 -m pip` runs the same pip module. ### API No API change. ### Documentation - [ ] `doc-needed` - [x] `doc-not-needed` - [ ] `doc-included` ### Was this patch authored or co-authored using generative AI tooling? - [x] Yes - [ ] No Generated-by: Claude Code 2.1.224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
