weiqingy commented on code in PR #926:
URL: https://github.com/apache/flink-agents/pull/926#discussion_r3746345187
##########
python/flink_agents/api/runner_context.py:
##########
@@ -24,12 +25,49 @@
from flink_agents.api.metric_group import MetricGroup
from flink_agents.api.resource import Resource, ResourceType
-__all__ = ["AsyncExecutionResult", "RunnerContext"]
+__all__ = ["AsyncExecutionResult", "DurableCall", "Outcome", "RunnerContext"]
if TYPE_CHECKING:
from flink_agents.api.memory_object import MemoryObject
+@dataclass(frozen=True)
+class DurableCall:
+ """A deterministic durable call entry for batch execution."""
+
+ id: str
Review Comment:
The code side is resolved: `DurableCall.id` is gone, and
`tool_call_action.py` no longer imports from `flink_agents.runtime`.
On the tech-debt follow-up that was suggested for bringing Python's durable
identity back in line with Java's `getId()` contract, I could not find an issue
tracking it. The closest is #956, which is scoped to the Tool result contract
(`ToolResponse` vs `Any`) and does not touch recovery identity or the class
names. Would it be worth opening one before this merges? Deferrals without an
issue behind them tend to quietly disappear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
