snuyanzin commented on code in PR #28858:
URL: https://github.com/apache/flink/pull/28858#discussion_r3747321507
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/common/OverAggregateTestPrograms.java:
##########
@@ -383,6 +386,60 @@ public class OverAggregateTestPrograms {
BEFORE_RESTORE_DATA_PRECEDING_ROWS_WITH_OUT_OF_ORDER_RECORDS,
AFTER_RESTORE_DATA_PRECEDING_ROWS_WITH_OUT_OF_ORDER_RECORDS);
+ /** Regression test for FLINK-25802: RANGE OVER with TIMESTAMP(3) ORDER BY
failed to compile. */
+ public static final TableTestProgram OVER_AGGREGATE_RANGE_TIMESTAMP =
Review Comment:
if we enable
```java
// OverAggregateTestPrograms.OVER_AGGREGATE_TIME_BOUNDED_PARTITIONED_ROWS,
//
OverAggregateTestPrograms.OVER_AGGREGATE_TIME_BOUNDED_NON_PARTITIONED_ROWS
```
is there something else which the existing tests do not check and we need
new?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
