Samrat002 commented on code in PR #28427:
URL: https://github.com/apache/flink/pull/28427#discussion_r3752039197


##########
flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/S3ClientProvider.java:
##########
@@ -682,6 +692,13 @@ S3ClientProvider build() {
                                 : "(CRT runtime default)");
             }
 
+            if (metricPublisher != null) {
+                // Re-wrap the immutable override config with the publisher 
attached. The same
+                // publisher feeds both the sync and async clients below.
+                overrideConfig =
+                        
overrideConfig.toBuilder().addMetricPublisher(metricPublisher).build();
+            }

Review Comment:
   fixed it now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to