weiqingy commented on PR #28952: URL: https://github.com/apache/flink/pull/28952#issuecomment-5245573579
Hi @RocMarshal, this is the runtime slice of the FLIP-497 stack, now that #28877 is merged. It makes the interval join emit the speculative padded row when the early-fire delay elapses, then retract and correct it if a real match arrives later. Two things worth your eye: - It adds a bookkeeping `MapState` recording whether a row has already early-fired. A savepoint taken before this change restores it empty, which just means a row is treated as not yet early-fired, so the worst case is a duplicate speculative row, never a swallowed retraction. - Early-fire timers are not deleted when a row matches or gets cleaned up. They fire once, find nothing, and go away, so it is self-clearing rather than a leak. With a large delay they do outlive the state they refer to. Happy to delete them explicitly if you would rather not carry that. PTAL when you have time. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
