weiqingy commented on code in PR #28954:
URL: https://github.com/apache/flink/pull/28954#discussion_r3755332602
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateFilteringHandler.java:
##########
@@ -462,6 +432,20 @@ List<Buffer> filterAndRewrite(
}
}
+ private VirtualChannel<T> getVirtualChannelBy(int oldSubtaskIndex, int
oldChannelIndex) {
Review Comment:
nit: The comment at line 363 marks everything below it as code that goes
away when FLINK-38544 lands. This new helper sits inside that section, but one
of its two callers is at line 325, in the overload that stays. Up to now
nothing inside the section was called from outside it, so that deletion could
be a clean cut. Would moving the helper above line 362 be worth it to keep that
true?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
