Dennis-Mircea commented on code in PR #1173:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1173#discussion_r3759498104
##########
docs/content/docs/managing/job-management.md:
##########
@@ -100,16 +100,16 @@ When a referenced Kubernetes resource changes, the
running job is not restarted
How state is carried across the restart is controlled through
`spec.job.upgradeMode`, with three supported values: `stateless`, `last-state`,
and `savepoint`. The setting controls both the stop and the restore mechanism,
as detailed in the following table:
-| | Stateless | Last State
| Savepoint |
-|------------------------|------------------|----------------------------------------|-------------------------------------------|
-| Config Requirement | None | Checkpointing Enabled
| Checkpoint or savepoint directory defined |
-| Job Status Requirement | None | Job or HA metadata accessible
| Job Running |
-| Suspend Mechanism | Cancel or delete | Cancel or delete (keeping HA
metadata) | Cancel with savepoint |
-| Restore Mechanism | Empty state | Use HA metadata or the latest
snapshot | Restore from savepoint |
-| Production Use | Not recommended | Recommended
| Recommended |
+| | Stateless | Last State
| Savepoint |
+|------------------------|------------------|----------------------------------------|--------------------------------------------|
+| Config Requirement | None | Checkpointing Enabled
| Checkpoint and savepoint directory defined |
+| Job Status Requirement | None | Job or HA metadata accessible
| Job Running |
+| Suspend Mechanism | Cancel or delete | Cancel or delete (keeping HA
metadata) | Cancel with savepoint |
+| Restore Mechanism | Empty state | Use HA metadata or the latest
snapshot | Restore from savepoint |
+| Production Use | Not recommended | Recommended
| Recommended |
{{< hint info >}}
-When HA is enabled the `savepoint` upgrade mode may fall back to the
`last-state` behavior in cases where the job is in an unhealthy state.
+When HA is enabled the `savepoint` upgrade mode may fall back to the
`last-state` behavior in cases where the job is in an unhealthy state. This is
why a checkpoint directory is required.
Review Comment:
This new added sentence is not accurate and is exactly what @gyfora was
referring to. The checkpoint directory is required for every non-stateless
upgrade mode. I'd propose here better framing like the one below:
```suggestion
When HA is enabled the `savepoint` upgrade mode may fall back to the
`last-state` behavior in cases where the job is in an unhealthy state,
restoring from the checkpoint directory. That fallback can be disabled with
`kubernetes.operator.job.upgrade.last-state-fallback.enabled`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
