jigar-bhati commented on code in PR #267:
URL: 
https://github.com/apache/flink-connector-kafka/pull/267#discussion_r3761954881


##########
flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/KafkaPropertiesUtilTest.java:
##########
@@ -63,6 +63,31 @@ void 
testClusterResetPropertyOverridesGlobalAndInitializerStrategies() {
                 .isEqualTo("earliest");
     }
 
+    @Test

Review Comment:
   Done. The test is now parameterized over every pair from 
`OffsetResetStrategy.values()`; with the current enum values that covers all 
3x3 combinations.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to