pltbkd commented on code in PR #938: URL: https://github.com/apache/flink-agents/pull/938#discussion_r3764958209
########## api/src/main/java/org/apache/flink/agents/api/subagent/Subagent.java: ########## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.agents.api.subagent; + +import org.apache.flink.agents.api.context.RunnerContext; + +/** + * Caller-facing interface for all sub-agents (external and internal). + * + * <p>An invocation is identified by a {@code (sessionId, callId)} pair; the session groups a + * conversation across invocations. Callers do not manage ids: the short forms below leave the + * missing ids to the implementation, which assigns them (runtime setups typically through a + * deterministic id allocator, stable across failover replays) or rejects the call. + * + * <p>The full form taking the complete {@code (sessionId, callId)} identity is the + * implementation-side contract, declared by {@link SubagentSetup}; resolving a returned handle is + * {@code await}. + */ +public interface Subagent { Review Comment: I view `Subagent` as a resource rather than a kind of agent: like `MCPServer` and `Tool`, the class name is the entity name. I split it off from `SubagentSetup` mainly because it's the user-facing surface — callers only see `submit()`, while the full-identity form and the resource plumbing stay on `SubagentSetup`. If the split itself is what reads as confusing, I'm fine merging it back into `SubagentSetup` and having callers use that directly — that's what `BaseChatModelSetup` does today. I'd also lean against a handle abstraction here: resources are used through direct method calls on the instance from the context, so a handle would only add a layer — the same reason we don't have `ChatModelChatter.chatTo(model)` or `ToolUser.use(tool)`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
