gustavodemorais commented on code in PR #28958:
URL: https://github.com/apache/flink/pull/28958#discussion_r3765308297
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/JsonFunctionsITCase.java:
##########
@@ -525,6 +528,10 @@ private static TestSetSpec jsonValueSpec() {
.testSqlResult(
"JSON_VALUE(f0, '$.type'), JSON_VALUE(f0, '$.age')",
List.of("account", "42"),
+ List.of(STRING(), STRING()))
+ .testSqlResult(
+ "JSON_VALUE(f1, '$.type'), JSON_VALUE(f2, '$.type')",
Review Comment:
The tests cover BYTES and ROW; The repro from the PR description isn't
tested or am I missing something? (SELECT json_value(null, '$.type'),
json_value(null, '$.type'))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
