dalelane opened a new pull request, #1176:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1176
Redeploying a suspended FlinkSessionJob from an explicit savepoint (state
SUSPENDED -> RUNNING via savepointRedeployNonce) always tried to cancel the job
first, even though the suspend clears the jobId. FlinkDeployment guards this
with isJobCancellable() but the session job path was missing the same guard.
## What is the purpose of the change
For a FlinkSessionJob, if a job is suspended with a savepoint, and the user
then tries to explicitly redeploy it from a specific savepoint path (by setting
spec.job.state=RUNNING, spec.job.initialSavepointPath, and bumping
spec.job.savepointRedeployNonce), the reconciler would fail.
## Brief change log
- Created a unit test to recreate the issue
- Copied the guard used for FlinkDeployment to FlinkSessionJob.
## Verifying this change
This change added a unit test. It can also be verified manually by
suspending a job on a session cluster and then resuming from a savepoint.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changes to the `CustomResourceDescriptors`:
no
- Core observer or reconciler logic that is regularly executed: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [ ] Yes (please specify the tool below)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
