Efrat19 commented on code in PR #292:
URL:
https://github.com/apache/flink-connector-kafka/pull/292#discussion_r3765592147
##########
flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/reader/KafkaPartitionSplitReaderTest.java:
##########
@@ -377,6 +379,40 @@ void testPauseOrResumeSplitsWithUnassignedPartition() {
Collections.singletonList(unassignedSplit));
}
+ @Test
+ public void testDefaultPollTimeout() {
+ // The default is part of the connector's behavior contract: changing
it would silently
+ // change how long the split reader blocks on idle partitions for all
existing jobs.
+
assertThat(createReader().getPollTimeout()).isEqualTo(Duration.ofSeconds(10));
Review Comment:
```suggestion
assertThat(createReader().getPollTimeout()).isEqualTo(KafkaSourceOptions.POLL_TIMEOUT_MS.defaultValue());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
