Dennis-Mircea commented on code in PR #1175:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1175#discussion_r3765683618
##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/metrics/OperatorJosdkMetricsTest.java:
##########
@@ -156,17 +156,13 @@ public boolean isLastAttempt() {
assertEquals(1, getCount("Resource.Event"));
assertEquals(1, getCount("Resource.Event.ADDED"));
- operatorMetrics.cleanupDone(resourceId, metadata);
Review Comment:
This line should not be deleted, and stay as is, because `cleanupDone` and
`reconciliationFinished` are interconnected. By having this line deleted it
suggests that the new change added as part of
`OperatorJosdkMetrics#cleanupDone` is not enough, and after the
`reconciliationFinished` the metrics are registered back by the JOSDK, so the
PR main idea is discarded completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
