rkhachatryan commented on code in PR #27026:
URL: https://github.com/apache/flink/pull/27026#discussion_r3769943805
##########
flink-filesystems/flink-s3-fs-base/src/main/java/org/apache/flink/fs/s3/common/writer/RecoverableMultiPartUploadImpl.java:
##########
@@ -322,14 +323,16 @@ private static class UploadTask implements Runnable {
@Override
public void run() {
try {
- final UploadPartResult result =
+ final UploadPartResponse result =
s3AccessHelper.uploadPart(
objectName,
uploadId,
partNumber,
file.getInputFile(),
file.getPos());
- future.complete(new PartETag(result.getPartNumber(),
result.getETag()));
+ final CompletedPart completedPart =
+
CompletedPart.builder().partNumber(partNumber).eTag(result.eTag()).build();
+ future.complete(completedPart);
Review Comment:
With SDK v2, this becomes incorrect if user sets
`s.s3a.checksum.generation=true`. In that case, S3 will require checksum per
part and fail the request because the checksum is missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
