[
https://issues.apache.org/jira/browse/FLINK-40382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-40382:
-----------------------------------
Labels: pull-request-available test-stability (was: test-stability)
> Serializer test variants in flink-table-type-utils are never executed
> ---------------------------------------------------------------------
>
> Key: FLINK-40382
> URL: https://issues.apache.org/jira/browse/FLINK-40382
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Runtime, Tests
> Reporter: Purushottam Sinha
> Priority: Major
> Labels: pull-request-available, test-stability
>
> h3. Problem
> RowDataSerializerTest, ExternalSerializerTest and TimestampDataSerializerTest
> declare their
> concrete variants as {{static}} nested classes, so 15 variants and 267 tests
> never execute.
> The module reports 151 tests instead of 418.
> h3. Cause
> Surefire excludes {{*{*}/{*}$*}} when scanning class files, and JUnit Jupiter
> only discovers
> {{@Nested}} inner classes — a {{static}} nested class falls through both. The
> abstract outer class produces no output either, so nothing in the build
> indicates the omission.
> h3. Evidence
> The variant class names appear zero times in any job of green master build
> 31416084933, while top-level siblings like MapDataSerializerTest each report
> 17 tests.
> h3. Fix
> Container class + {{abstract static}} base + {{@Nested}} variants, per
> MaxWithRetractAggFu
> RowDataSerializerTest instead gets top-level variants, since its {{private
> static}} helpers called from {{super(...)}} are illegal in an inner class at
> source level 11. No logic changes; 41
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
