gyfora commented on code in PR #1178:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1178#discussion_r3773168573
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkRuntimeConfigurationUtils.java:
##########
@@ -141,10 +147,30 @@ public static Map<String, String>
mapJobConfiguration(JobConfigInfo configuratio
jobConfig.put(
CoreOptions.DEFAULT_PARALLELISM.key(),
String.valueOf(execInfo.getParallelism()));
jobConfig.put(PipelineOptions.OBJECT_REUSE.key(),
String.valueOf(execInfo.isObjectReuse()));
- jobConfig.putAll(execInfo.getGlobalJobParameters());
+ execInfo.getGlobalJobParameters()
+ .forEach(
+ (key, value) -> {
+ if (isOperatorControlledKey(key)) {
+ LOG.warn(
+ "Ignoring global job parameter '{}':
the job cannot override operator configuration.",
Review Comment:
Let's remove this log, it's basically unnecessary and does not communicate
anything interesting to the operator. Operator configs are not job configs
anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
