yuxiqian commented on code in PR #4504:
URL: https://github.com/apache/flink-cdc/pull/4504#discussion_r3775256011
##########
flink-cdc-cli/src/main/java/org/apache/flink/cdc/cli/parser/YamlPipelineDefinitionParser.java:
##########
@@ -96,9 +97,11 @@ public class YamlPipelineDefinitionParser implements
PipelineDefinitionParser {
private static final String UDF_OPTIONS_KEY = "options";
// Model related keys
- private static final String MODEL_NAME_KEY = "model-name";
-
- private static final String MODEL_CLASS_NAME_KEY = "class-name";
+ private static final String MODEL_NAME_KEY = "name";
+ private static final String MODEL_TYPE_KEY = "type";
+ private static final String MODEL_OPTIONS_KEY = "options";
+ private static final String LEGACY_MODEL_NAME_KEY = "model-name";
+ private static final String LEGACY_MODEL_CLASS_NAME_KEY = "class-name";
Review Comment:
You're right, it's reasonable to keep it for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
