weiqingy commented on code in PR #1005:
URL: https://github.com/apache/flink-agents/pull/1005#discussion_r3781344787
##########
api/src/test/java/org/apache/flink/agents/api/skills/SkillsResourceTest.java:
##########
@@ -65,6 +122,16 @@ void roundTripsThroughJackson() throws Exception {
assertEquals(original.getSources(), restored.getSources());
}
+ @Test
+ void pinnedUrlRoundTripsThroughJackson() throws Exception {
Review Comment:
nit: this round trip stops at `sha256`, and
`test_skills.py::test_serialize_roundtrip` does the same, so
`allow_insecure_http` isn't covered on either side.
I compared what the two languages emit and they match exactly — both write
the flag as the string `"true"` and omit it otherwise, and both read it back
the same way — so there's no bug here today. The only gap is that nothing would
catch it if they drifted. Raising it because #1003 mentions alignment
"including plan serialization".
Would adding the flag to this test and its Python counterpart be enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
