wenjin272 commented on PR #1007: URL: https://github.com/apache/flink-agents/pull/1007#issuecomment-5293450905
Thanks for the update. Deriving the default Flink version from the root POM looks good. One concern with the current CLI contract is that `-f` affects Python unit tests but not Java unit tests. Since CI runs UTs only against the default version and uses the E2E/IT matrix for multi-version coverage, could we scope `-f` to E2E tests only? Both Java and Python UTs would then consistently use the root POM version, and `-f` without `-e` could be rejected with a clear error. The current examples should also be updated: ```bash $0 -f 2.2 # Run tests only for Flink 2.2 ``` This is not accurate because Java UTs still use the root POM version. If `-f` is E2E-only, the example could use `-e -f 2.2` instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
