VasShabu opened a new pull request, #28978:
URL: https://github.com/apache/flink/pull/28978
<!--
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve Flink. To help the community review your
contribution in the best possible way, please go through the checklist below,
which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a
hassle. In order to uphold a high standard of quality for code contributions,
while at the same time managing a large number of contributions, we need
contributors to prepare the contributions well, and give reviewers enough
contextual information for the review. Please also understand that
contributions that do not follow this guide will take longer to review and thus
typically be picked up with lower priority by the community.*
## What is the purpose of the change
This pull request alters JSON_LENGTH's codeGen to be inline with JSON_TYPE,
as these 2 functions are very similar in nature its smart to ensure that the
planning stage works the same way.
*(For example: This pull request makes task deployment go through the blob
server, rather than through RPC. That way we avoid re-transferring them on each
deployment (during recovery).)*
## Brief change log
*(for example:)*
- Alters JSON_LENGTH's prefix regex so that it doesnt miss any cases
- isPathDefinite function got moved to the Codegen stage in order to call
a validation error over a runtime error
- JSON_LENGTH test cases got changed to accomodate for the new validation
error
- reuse getOrCreateParsedJson(jsonType) for jsonLength
## Verifying this change
Please make sure both new and modified tests in this PR follow [the
conventions for tests defined in our code quality
guide](https://flink.apache.org/how-to-contribute/code-style-and-quality-common/#7-testing).
*(Please pick either of the following options)*
This change added tests and can be verified as follows:
./mvnw -o -pl flink-table/flink-table-planner -Dtest='JsonFunctionsITCase'
-Dsurefire.failIfNoSpecifiedTests=false -Dcheckstyle.skip=true
-Dspotless.check.skip=true -Drat.skip=true -e -Denforcer.skip=true test
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (yes)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (don't know)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (yno)
- If yes, how is the feature documented? (not documented) (just
optimisation)
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change the checkbox below to `[X]` and replace the placeholder in the
"Generated-by"
line with the tool name and version. Otherwise remove the "Generated-by"
line.
See the ASF Generative Tooling Guidance for details:
https://www.apache.org/legal/generative-tooling.html
You are responsible for the quality and correctness of every change in this
PR
regardless of the tooling used. Low-effort AI-generated PRs will be closed.
See
AGENTS.md for the full guidance.
-->
- [X] Yes (please specify the tool below)
Generated-by: Claude Opus 5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
