purushah commented on code in PR #1030:
URL: https://github.com/apache/flink-agents/pull/1030#discussion_r3840895781
##########
api/src/main/java/org/apache/flink/agents/api/context/MemoryUpdate.java:
##########
@@ -32,17 +32,36 @@ public class MemoryUpdate implements Serializable {
private final String path;
private final Object value;
+ private final boolean objectCreation;
/**
- * Creates a new MemoryUpdate instance.
+ * Creates a new MemoryUpdate instance describing a value write.
*
* @param path the absolute path of the data in Short-Term Memory.
* @param value the new value to set at the specified path.
*/
+ public MemoryUpdate(String path, Object value) {
+ this(path, value, false);
+ }
+
+ /**
+ * Creates a new MemoryUpdate instance.
+ *
+ * @param path the absolute path of the data in Short-Term Memory.
+ * @param value the new value to set at the specified path; always null
when {@code
+ * objectCreation} is true.
+ * @param objectCreation true if this update records the creation of a
nested object rather than
+ * a value write. Absent in records written before this field existed,
in which case Jackson
+ * defaults it to false, preserving their original replay behavior.
+ */
@JsonCreator
- public MemoryUpdate(@JsonProperty("path") String path,
@JsonProperty("value") Object value) {
+ public MemoryUpdate(
+ @JsonProperty("path") String path,
+ @JsonProperty("value") Object value,
+ @JsonProperty("objectCreation") boolean objectCreation) {
Review Comment:
Good catch — done in 4edd5f6. The creator now throws
`IllegalArgumentException` when `objectCreation=true` carries a non-null value,
so a malformed update fails loudly at construction/deserialization time instead
of the replayer silently dropping the value.
##########
runtime/src/test/java/org/apache/flink/agents/runtime/actionstate/ActionStateSerdeTest.java:
##########
@@ -61,11 +61,13 @@ public void testActionStateSerializationDeserialization()
throws Exception {
MemoryUpdate sensoryMemoryUpdate = new MemoryUpdate("sm.test.path",
"sm test value");
MemoryUpdate shortTermMemoryUpdate = new MemoryUpdate("stm.test.path",
"stm test value");
+ MemoryUpdate objectCreationUpdate = new MemoryUpdate("stm.test.obj",
null, true);
Review Comment:
Added in 4edd5f6:
`testLegacyRecordWithoutObjectCreationFieldDefaultsToFalse` serializes a state,
strips the `objectCreation` field from the JSON (simulating a record written by
the old serializer), deserializes through `ActionStateSerde`, and asserts the
update comes back as a value write with `isObjectCreation() == false`.
##########
runtime/src/test/java/org/apache/flink/agents/runtime/memory/MemoryUpdateReplayerTest.java:
##########
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.flink.agents.runtime.memory;
+
+import org.apache.flink.agents.api.context.MemoryObject;
+import org.apache.flink.agents.api.context.MemoryUpdate;
+import org.junit.jupiter.api.Test;
+
+import java.util.LinkedList;
+import java.util.List;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatCode;
+
+/**
+ * Tests for {@link MemoryUpdateReplayer}: durable-execution replay of the
{@link MemoryUpdate}s
+ * recorded by a completed action must reproduce the action's memory effects,
in particular for
+ * updates recorded by {@code newObject}, which are not value writes.
+ */
+public class MemoryUpdateReplayerTest {
+
+ private static MemoryObject freshMemory(List<MemoryUpdate> updates) throws
Exception {
+ return new MemoryObjectImpl(
+ MemoryObject.MemoryType.SHORT_TERM,
+ new CachedMemoryStore(new ForTestMemoryMapState<>()),
+ MemoryObjectImpl.ROOT_KEY,
+ updates);
+ }
+
+ /** Runs an "action" against a fresh memory and returns the updates it
recorded. */
+ private static List<MemoryUpdate>
recordUpdates(ThrowingConsumer<MemoryObject> action)
+ throws Exception {
+ List<MemoryUpdate> updates = new LinkedList<>();
+ MemoryObject memory = freshMemory(updates);
+ action.accept(memory);
+ return updates;
+ }
+
+ @FunctionalInterface
+ private interface ThrowingConsumer<T> {
+ void accept(T t) throws Exception;
+ }
+
+ @Test
+ void testReplayNewObjectWithChildWritesIntoEmptyState() throws Exception {
Review Comment:
Added in 4edd5f6: `testReplayLoneNewObjectPreservesEmptyNestedObject`
replays an action that only called `newObject("empty")` and asserts the result
is an empty nested object (`isNestedObject()` true, no field names, null value)
rather than a null leaf.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
