AHeise commented on PR #290: URL: https://github.com/apache/flink-connector-kafka/pull/290#issuecomment-5391953419
> > One simplification on the locking, though: I don't think `pendingWakeup`/`consumerLock` are reachable in practice, so we can drop them (and the lock) entirely. > > cc @dalelane since #293 introduces another consumer access from the main thread (to determine the right position to commit on checkpoint) @AHeise wdyt Let's work it out with @dalelane before merging. Imho it should be fine: if there is no consumer, there are no offsets to commit. I'll also comment on that PR; I think that approach is unnecessarily complex. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
