raminqaf commented on code in PR #28928:
URL: https://github.com/apache/flink/pull/28928#discussion_r3842481054


##########
flink-table/flink-table-type-utils/src/main/java/org/apache/flink/table/data/conversion/DataStructureConverters.java:
##########
@@ -198,6 +199,7 @@ public final class DataStructureConverters {
         putConverter(LogicalTypeRoot.RAW, byte[].class, 
RawByteArrayConverter::create);
         putConverter(LogicalTypeRoot.RAW, RawValueData.class, identity());
         putConverter(LogicalTypeRoot.VARIANT, Variant.class, identity());
+        putConverter(LogicalTypeRoot.VARIANT, BinaryVariant.class, identity());

Review Comment:
   Made `BinaryVariant` internal-only across every conversion registry 
(`VariantType`, `DataStructureConverters`, `ClassDataTypeConverter`) + fixed 
`ValueDataTypeConverter` to bridge to the Variant interface; updated four unit 
tests. Mirrors how `BinaryStringData` is hidden behind `StringData`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to