raminqaf opened a new pull request, #29023:
URL: https://github.com/apache/flink/pull/29023
## What is the purpose of the change
Test-only follow-up to the FLINK-40207 cast fix. `BinaryStringDataTest` used
Flink's custom `ParameterizedTestExtension` (constructor-injected `Mode`,
`@TestTemplate`, `@Parameters`), and several methods bundled many unrelated
scenarios into one body. This reworks it to plain JUnit 5 for readability and
more granular reporting. There is no production code change and no behavior
change under test.
## Brief change log
- Replaced `ParameterizedTestExtension` with plain JUnit 5. The
memory-layout axis is now a method parameter: layout-dependent tests are
`@ParameterizedTest` over `@EnumSource(Mode.class)` and build strings through a
static `fromString(Mode, String)`.
- Layout-independent tests are now plain `@Test` (run once) instead of
running four identical times. This includes the two binary-row blocks
previously nested inside the numeric and decimal tests, which never used the
layout helper.
- Grouped tests into `@Nested` classes by concern: `Basics`, `Comparison`,
`Search`, `Manipulation`, `Conversion`, `Encoding`.
- Moved the string-to-decimal cases into a shared list fed to a
`@MethodSource`, so each case is its own reported invocation.
- Split the two oversized methods: the numeric test into integral /
approximate-special-value / binary-row tests, and the decimal test into string
/ binary-row tests.
## Verifying this change
This change is test-only and is verified by the tests themselves. The full
class passes (279 invocations across the six nested groups, 0 failures). No
assertions were dropped: every prior scenario maps forward, and the 49 decimal
cases are unchanged.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change the checkbox below to `[X]` and replace the placeholder in the
"Generated-by"
line with the tool name and version. Otherwise remove the "Generated-by"
line.
See the ASF Generative Tooling Guidance for details:
https://www.apache.org/legal/generative-tooling.html
You are responsible for the quality and correctness of every change in this
PR
regardless of the tooling used. Low-effort AI-generated PRs will be closed.
See
AGENTS.md for the full guidance.
-->
- [ ] Yes (please specify the tool below)
Generated-by: [Tool Name and Version]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
