Dennis-Mircea commented on code in PR #1194:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1194#discussion_r3864596783
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkOperatorConfiguration.java:
##########
@@ -210,7 +210,8 @@ public static FlinkOperatorConfiguration
fromConfiguration(Configuration operato
operatorConfig.get(KubernetesOperatorConfigOptions.OPERATOR_EVENT_EXCEPTION_LIMIT);
int reportedExceptionEventsMaxStackTraceLength =
operatorConfig.get(
-
KubernetesOperatorConfigOptions.OPERATOR_EVENT_EXCEPTION_STACKTRACE_LINES);
Review Comment:
Wouldn't be better/safer to first deprecate this option that was introduced
as part of 1.12.0 operator release and remove it in further releases?
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/KubernetesOperatorConfigOptions.java:
##########
@@ -780,12 +780,12 @@ public static String operatorConfigKey(String key) {
"How often to retrieve Kubernetes cluster resource
usage information. This information is used to avoid running out of cluster
resources when scaling up resources. Negative values disable the feature.");
@Documentation.Section(SECTION_ADVANCED_RECONCILE)
- public static final ConfigOption<Integer>
OPERATOR_EVENT_EXCEPTION_STACKTRACE_LINES =
- operatorConfig("events.exceptions.stacktrace-lines")
+ public static final ConfigOption<Integer>
OPERATOR_EVENT_EXCEPTION_STACKTRACE_MAX_LENGTH =
+ operatorConfig("events.exceptions.stacktrace.max.length")
Review Comment:
I'd say it's good to add a defensive support for negative values, and maybe
consider `-1` value as unlimited length.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
