Dennis-Mircea commented on code in PR #1195:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1195#discussion_r3870409730
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/kubeclient/decorators/FlinkConfMountDecorator.java:
##########
@@ -249,4 +251,20 @@ public String getFlinkConfFilename() {
public static boolean useStandardYamlConfig(FlinkVersion flinkVersion) {
return flinkVersion != null &&
flinkVersion.isEqualOrNewer(FlinkVersion.v2_0);
}
+
+ /**
+ * Re-parses Map-typed options that arrive already serialized to a String
(e.g. the autoscaler
+ * parallelism overrides stored in the CR spec) and sets them back as
typed values.
+ */
+ public static void normalizeMapTypedOptions(Configuration source,
Configuration target) {
+ if (!source.containsKey(PipelineOptions.PARALLELISM_OVERRIDES.key())) {
Review Comment:
Yep, that's true. The only case that I thought about was also a downgrade
that may happen, but still the operator is writing the YAML in legacy format
now, so it will not be a problem anymore. I'll revert this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
