weiqingy commented on PR #981:
URL: https://github.com/apache/flink-agents/pull/981#issuecomment-5467101438
Both findings are fixed, thanks for catching them.
**Jackson naming** (`5230d2ce`): answered inline.
**Live coverage** (`6f10f490`): `test_ollama_chat_with_output_schema` sends
a `BaseModel` schema down the native path and reads the reply back with
`model_validate_json`, in the integration arm where CI already runs Ollama. It
reuses the marker, model pull and skip check already in that file, so nothing
new is gated.
It checks the shape, not the values. The server enforces the grammar, so
`{"name": "", "age": 0}` from a 1.7b model is a fair pass, and asserting a
value would only make it flaky. To be sure it was not just passing on a model
that emits JSON anyway, I reran the same call with the schema removed and got
prose back, which fails the test.
On POJO/Pydantic: only the Pydantic side is live. The Java connector's own
tests do not run in a lane that has Ollama, so a Java version would have to sit
in the e2e integration module.
**`supportsNativeStructuredOutput()`**: agreed. I will put the user-facing
documentation on #912, next to the strategy resolution and fallback behavior.
On the guide: yes, let's start it. I will open a PR for it and ask for your
review soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
